feat(tasks): add cloud hogland runtime option to workspace picker#2387
Draft
webjunkie wants to merge 1 commit into
Draft
feat(tasks): add cloud hogland runtime option to workspace picker#2387webjunkie wants to merge 1 commit into
webjunkie wants to merge 1 commit into
Conversation
Adds a "Cloud · Hogland" entry alongside the existing "Default" cloud choice in WorkspaceModeSelect. Selecting it sends sandbox_runtime=posthog on createTaskRun, which the posthog backend maps to the hogland sandbox adapter (see feat/tasks-hogland-sandbox-runtime). Gated behind feature flag tasks-hogland-runtime so we can dark-launch. The new sandbox_runtime field is orthogonal to sandbox_environment_id: runtime picks the backend infra, environment picks the network policy. Picking a user env or "Default" clears the runtime; picking Hogland clears the env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adds a "Cloud · Hogland" entry to the workspace picker so we can dark-launch the new hogland sandbox backend (see posthog/posthog#60042) end-to-end without committing to it as the default. Lets us A/B against the current Modal cloud runtime per-run.
Changes
WorkspaceModeSelect: new "Cloud · Hogland" row alongside the existing "Default", gated by feature flagtasks-hogland-runtime(on in dev). Picking Hogland clears the cloud environment selection; picking Default or a user env clears the runtime. Trigger label reflects the active choice.sandboxRuntimethroughTaskInput→useTaskCreation→TaskCreationSaga→createTaskRun, where it's serialized as the existing backend fieldsandbox_runtime.sandbox_runtimeandsandbox_environment_idare orthogonal: runtime picks the backend infra, environment picks the network policy. Mutually exclusive in this PR by design — if we ever want a per-env default runtime, that's a separate column onSandboxEnvironment.Handoff is intentionally not touched. New cloud runs only.
How did you test this?
Local diff review against the existing
sandboxEnvironmentIdplumbing — same pattern, parallel field. Did not run typecheck (nopnpm installyet); the changes follow the existing patterns 1:1 so I'd be surprised if anything breaks, but worth runningpnpm --filter @posthog/code typecheckbefore merging.Publish to changelog?
no