Skip to content

Make Fuzzy Gdown Argument Version-dependent#8986

Merged
ericspod merged 5 commits into
Project-MONAI:devfrom
ericspod:fuzzy_fix
Jul 20, 2026
Merged

Make Fuzzy Gdown Argument Version-dependent#8986
ericspod merged 5 commits into
Project-MONAI:devfrom
ericspod:fuzzy_fix

Conversation

@ericspod

@ericspod ericspod commented Jul 9, 2026

Copy link
Copy Markdown
Member

Description

Gdown has dropped the "fuzzy" argument in version 6.0.0. This PR makes the argument dependent on the Gdown version being below this, and removes it where it's not needed.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod
ericspod requested review from KumoLiu and Nic-Ma as code owners July 9, 2026 01:22
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 99c345f4-5159-46d8-b63f-5fdf022530f1

📥 Commits

Reviewing files that changed from the base of the PR and between 9a5395b and 5a973c2.

📒 Files selected for processing (1)
  • monai/bundle/scripts.py
💤 Files with no reviewable changes (1)
  • monai/bundle/scripts.py

📝 Walkthrough

Walkthrough

download_url now sets the Google Drive fuzzy default only when gdown is older than 6.0.0 and the caller did not provide it. download_large_files stops forcing fuzzy=True before calling download_url, and both HoverNet pretrained-weight download calls remove fuzzy=True.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: making the gdown fuzzy argument version-dependent.
Description check ✅ Passed The description includes the required Description and Types of changes sections and is sufficiently complete for review.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ericspod
ericspod requested a review from garciadias July 9, 2026 01:23
ericspod added 2 commits July 8, 2026 21:40
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Comment thread monai/apps/utils.py
Comment thread monai/apps/utils.py

@garciadias garciadias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, correct, well-scoped compatibility fix for gdown 6.0.0 dropping the fuzzy argument. Left two optional minor follow-up suggestions inline (an edge case with explicit caller-supplied fuzzy on gdown>=6.0.0, and optional test coverage for the version-conditional branch) — neither is blocking.

@ericspod
ericspod enabled auto-merge (squash) July 20, 2026 10:48
@ericspod
ericspod merged commit 8885fcb into Project-MONAI:dev Jul 20, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants