Make Fuzzy Gdown Argument Version-dependent#8986
Conversation
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
garciadias
left a comment
There was a problem hiding this comment.
Small, correct, well-scoped compatibility fix for gdown 6.0.0 dropping the fuzzy argument. Left two optional minor follow-up suggestions inline (an edge case with explicit caller-supplied fuzzy on gdown>=6.0.0, and optional test coverage for the version-conditional branch) — neither is blocking.
Description
Gdown has dropped the "fuzzy" argument in version 6.0.0. This PR makes the argument dependent on the Gdown version being below this, and removes it where it's not needed.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.