Open
Conversation
Member
Author
|
We need to be a bit careful about releasing a version here, since i removed the monkey patching of snakemake-storage-plugin-http, so this would give us, if both are installled: I guess i could leave the monkey patching in place for a grace period and warn about the future incompatibility? |
Closed
Member
|
I mean this is currently used for PyPSA-Eur and forks only. We can just pin the current version in Eur, release here a new version, and remove the pin and remove the default storage provider |
ef5edfd to
4eade7f
Compare
Member
Author
|
Yes, but since the update cycles of the soft-forks are somewhat irregular, let's just take the safe route and keep the monkey-patching around a bit longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5 .
With this change we re-introduce general http(s) urls based on a http head request, so that cached-http becomes a complete replacement for the original http plugin.
Of note: if head requests are unsupported, the plugin assumes the requested url exists with an mtime of 0.