Skip to content

fix: 🐛 Complete user update methods#3103

Merged
Paillat-dev merged 27 commits intoPycord-Development:masterfrom
ToothyDev:fix/complete-user-update-methods
Feb 19, 2026
Merged

fix: 🐛 Complete user update methods#3103
Paillat-dev merged 27 commits intoPycord-Development:masterfrom
ToothyDev:fix/complete-user-update-methods

Conversation

@ToothyDev
Copy link
Contributor

@ToothyDev ToothyDev commented Feb 14, 2026

Summary

Not all user object updates triggered the on_user_update_event, see the exact attributes which were missing in #3078
Also fixes an issue where User.nameplate is broken and inaccessible

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Fixes #3078
Depends on #3107

@pycord-app
Copy link

pycord-app bot commented Feb 14, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3103/head:pr-3103
git checkout pr-3103

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3103/head

@Paillat-dev
Copy link
Member

image

@ToothyDev
Copy link
Contributor Author

ToothyDev commented Feb 14, 2026

I think I added all possible ones here for now. The missing ones are described in #3078 (comment) with a reason. accent_color might be doable as well but I wasn't sure because it would introduce potentially blocking // time-delaying code otherwise sync code.

Also, I tested all cases I could think of for now, but please do test as well in case I forgot about any

@Paillat-dev Paillat-dev added this to the v2.8.0rc.1 milestone Feb 17, 2026
…ethods

# Conflicts:
#	CHANGELOG.md
#	discord/member.py
#	discord/types/user.py
#	discord/user.py
# Conflicts:
#	discord/collectibles.py
#	discord/member.py
#	discord/types/member.py
#	discord/types/user.py
@ToothyDev
Copy link
Contributor Author

Due to many attributes not being accessible or documented on the API and the nameplate being handled in #3107, this leaves just the avatar decoration data to trigger the event

plun1331
plun1331 previously approved these changes Feb 18, 2026
@Soheab Soheab removed status: in progress Work in Progess API reflection Discord API isn't correctly reflected on hold labels Feb 18, 2026
@Paillat-dev Paillat-dev added hold: testing This pull request requires further testing and removed status: awaiting review Awaiting review from a maintainer labels Feb 18, 2026
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work fine; code lgtm; yippie

@Paillat-dev Paillat-dev removed the hold: testing This pull request requires further testing label Feb 19, 2026
@Paillat-dev Paillat-dev merged commit 6efa686 into Pycord-Development:master Feb 19, 2026
24 of 25 checks passed
@ToothyDev ToothyDev deleted the fix/complete-user-update-methods branch February 19, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: medium Medium Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Our user update method(s) might miss some parts

5 participants