Support a reusable 'var_cache' within the IdentifyVariableVisitor#3966
Open
jsiirola wants to merge 5 commits into
Open
Support a reusable 'var_cache' within the IdentifyVariableVisitor#3966jsiirola wants to merge 5 commits into
IdentifyVariableVisitor#3966jsiirola wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
=======================================
Coverage 90.11% 90.12%
=======================================
Files 909 909
Lines 108580 108641 +61
=======================================
+ Hits 97847 97912 +65
+ Misses 10733 10729 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IdentifyVariableVisitorIdentifyVariableVisitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This implements a minor performance improvement when we want to collect all the variables used by a model. The previous implementation ended up using two "seen" caches: one within the IdentifyVariableVisitor, and the other in the
get_var_from_components()utility. This allows a client to instantiate an IdentifyVariableVisitor with a persistent "seen" cache, thereby eliminating the redundant caches.This implementation is fully backwards compatible with the previous
IdentifyVariableViaitor/identify_variablesimplementation.Changes proposed in this PR:
IdentifyVariableVisitorget_vars_from_componentsto use a single persistent "seen" cacheget_vars()utility that is an alias forget_vars_from_components(ctype=(Constraint, Objective))AI-Use Disclosure
or
AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional):
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: