Repository navigation
[MRG] Handle both endpoints in sample-ratio splitting - #878
Open
AHMETHAKANBEZIR1 wants to merge 11 commits into
Open
AHMETHAKANBEZIR1 wants to merge 11 commits into
AHMETHAKANBEZIR1 wants to merge 11 commits into
Conversation
Return both endpoint distributions and matching selectors before accessing a boundary weight beyond the end of the array. Co-authored-by: Codex <noreply@openai.com>
…dpoint # Conflicts: # RELEASES.md
…dpoint # Conflicts: # RELEASES.md
…dpoint # Conflicts: # RELEASES.md
This was referenced Nov 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 130 130
Lines 27095 27122 +27
=======================================
+ Hits 26302 26329 +27
Misses 793 793 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877. At
ratio=1,split_sample_ratiosearches past the final weight and raises an indexing error. Atratio=0, TensorFlow's scalarsearchsortedpath also raises before returning the empty/full split.Return the full and empty distributions directly at both supported endpoints, after the existing optional permutation. Preserve weights, backend, shapes and selectors; interior-ratio weight computation is unchanged. The endpoint regressions cover supplied/default weights, zero weights, randomized/deterministic splits, membership, weight order and selectors.
Current validation
Current head
f0386a1includes masterf48a63a. OnlyRELEASES.mdconflicted; both release entries are retained. The PR production and regression files are byte-for-byte unchanged from its previous head.Complete utility module and doctests: NumPy 125 passed, 1 skipped; NumPy/PyTorch 2.9.1 CPU 189 passed, 1 skipped; NumPy/TensorFlow 157 passed, 33 skipped. Each process asserts the actual backend list and source checkout. Torch and TensorFlow run in separate environments. Skips are reported, not counted as passes.
The updated master's native extensions were rebuilt locally with the existing MSVC/Cython toolchain; the results above were repeated against that build. No native solver correctness or performance claim follows from the utility tests.
All applicable configured pre-commit hooks for the PR files and diff checks pass.
A private integration of [MRG] Fix sparse simplex projection with oversized budgets #876, [MRG] Handle both endpoints in sample-ratio splitting #878 and [MRG] Stabilize simplex projection against large common offsets #880 on the same master passes the utility module/doctests: NumPy 145 passed, 1 skipped; NumPy/PyTorch 229 passed, 1 skipped; NumPy/TensorFlow 197 passed, 33 skipped. That local integration branch is not published and is not part of this PR.
Windows/Python 3.12.14, CPU only. The full package suite, current full documentation/gallery, GPU, JAX and CuPy were not run locally. Current-head CircleCI documentation build 4316 completed successfully, with its commit verified against this PR head; all three reported checks now pass. This is an upstream full documentation build, not a local gallery run.
AI assistance disclosure
Prepared, investigated and tested autonomously by OpenAI Codex on behalf of AHMETHAKANBEZIR1. No independent human review has been performed.