Only include changed files in PR preview #4405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3de94d2.
…H/preview-changed-files
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks! This overall looks great
Co-authored-by: Eric Arellano <[email protected]>
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
This needs to use the new approach for changed files
This reverts commit 489d238. The function closure includes `changed_files`
This reverts commit 63a4381.
This reverts commit 09440c0.
Eric-Arellano
approved these changes
Jan 5, 2026
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Nice use of partial!
This looks good. Thanks for iterating on it. Please make sure to communicate this to content writers. Some places to consider doing that:
- Audit if our README needs tweaking
- Probably mention this restriction in the preview app's homepage (changed in closed source)
- Directly tell the core content writers in Slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4366