feat(service-settings): add advanced settings views#2440
feat(service-settings): add advanced settings views#2440rmnbrd merged 2 commits intonew-navigationfrom
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2440 +/- ##
=================================================
Coverage ? 44.41%
=================================================
Files ? 637
Lines ? 14657
Branches ? 4309
=================================================
Hits ? 6510
Misses ? 7017
Partials ? 1130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } = useParams({ | ||
| strict: false, | ||
| }) | ||
| const { data: service } = useService({ environmentId, serviceId }) |
There was a problem hiding this comment.
This query does not use suspense
| organizationId, | ||
| projectId, | ||
| service: { | ||
| service, |
There was a problem hiding this comment.
Should we start refactoring components that have these route-related props?
I'd prefer to use the router's hook to retrieve them instead of passing them down everywhere
…s for organization and project IDs
Summary
SettingsHeadingScreenshots / Recordings
https://www.loom.com/share/857106d5dc4546a1a485596997ffee84
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release