Skip to content

feat(service-settings): add advanced settings views#2440

Merged
rmnbrd merged 2 commits intonew-navigationfrom
feat/new-nav/service-advanced-settings
Mar 9, 2026
Merged

feat(service-settings): add advanced settings views#2440
rmnbrd merged 2 commits intonew-navigationfrom
feat/new-nav/service-advanced-settings

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Mar 3, 2026

Summary

  • Add new view Advanced Settings for Service
  • Fix Cluster circular dependencies with SettingsHeading
  • Fix UI for breacrumb min height with only one element in the list

Screenshots / Recordings

https://www.loom.com/share/857106d5dc4546a1a485596997ffee84

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Programs must be written for people to read, and only incidentally for machines to execute

@RemiBonnet RemiBonnet marked this pull request as ready for review March 3, 2026 14:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 17.74194% with 51 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@e102b71). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ced-settings/cluster-advanced-settings-feature.tsx 0.00% 29 Missing ⚠️
...ce-advanced-settings/service-advanced-settings.tsx 37.93% 9 Missing and 9 partials ⚠️
...oks/use-advanced-settings/use-advanced-settings.ts 0.00% 2 Missing ⚠️
...advanced-settings/use-default-advanced-settings.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2440   +/-   ##
=================================================
  Coverage                  ?   44.41%           
=================================================
  Files                     ?      637           
  Lines                     ?    14657           
  Branches                  ?     4309           
=================================================
  Hits                      ?     6510           
  Misses                    ?     7017           
  Partials                  ?     1130           
Flag Coverage Δ
unittests 44.41% <17.74%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RemiBonnet RemiBonnet requested a review from rmnbrd March 5, 2026 10:57
@RemiBonnet RemiBonnet added the V5 label Mar 5, 2026
} = useParams({
strict: false,
})
const { data: service } = useService({ environmentId, serviceId })
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query does not use suspense

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ! 258e253

Comment on lines +57 to +59
organizationId,
projectId,
service: {
service,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start refactoring components that have these route-related props?
I'd prefer to use the router's hook to retrieve them instead of passing them down everywhere

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ! 258e253

@RemiBonnet RemiBonnet requested a review from rmnbrd March 9, 2026 13:41
@rmnbrd rmnbrd merged commit b37acbb into new-navigation Mar 9, 2026
11 checks passed
@rmnbrd rmnbrd deleted the feat/new-nav/service-advanced-settings branch March 9, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants