Allow setting summary statistics during Initialize - #9855
Merged
Martin-Molinero merged 1 commit intoOct 1, 2026
Merged
Martin-Molinero merged 1 commit into
Martin-Molinero merged 1 commit into
Conversation
SetSummaryStatistic threw a null reference when called from Initialize because the statistics service is attached after setup runs. Keep the statistics set before the service is available and apply them once it's attached. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QCAlgorithm.SetSummaryStatisticnow keeps statistics set before the statistics service is attached, andSetStatisticsServiceapplies them once the result handler provides the service. Previously the call dereferenced a null_statisticsService.Related Issue
Closes #9853
Motivation and Context
The statistics service is attached in the result handler's
SetAlgorithm, whichEngine.Runcalls afterSetup.Setup(...)has already executedInitialize(), so callingSetSummaryStatistic/set_summary_statisticfromInitializefailed withObject reference not set to an instance of an object.Requires Documentation Change
No
How Has This Been Tested?
Extended the
StatisticsResultsAlgorithmregression (C# and Python) to set a summary statistic inInitializeand assert it is present inStatistics.SummaryatOnEndOfAlgorithm. Both variants fail with the reported null reference without the fix and pass with it.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>🤖 Generated with Claude Code