fix: resolve CI type-check errors (lodash types, Buffer→Uint8Array)#32
Merged
fix: resolve CI type-check errors (lodash types, Buffer→Uint8Array)#32
Conversation
- Install @types/lodash.throttle (fixes missing declaration for @myst-theme/site upstream import) - Convert Buffer to Uint8Array in [objects.inv].tsx and [favicon.ico].tsx (Buffer no longer assignable to BodyInit in newer @types/node)
mmcky
added a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI Type-Check Errors
The new CI pipeline (PR #31) correctly caught 3 pre-existing TypeScript errors that were previously invisible (no CI existed before).
Fixes
@types/lodash.throttle— Added as devDependency.@myst-theme/siteships.tsxsource files (not compiled.d.ts), so TypeScript follows imports into the package and needs this type declaration.Buffer→Uint8Arrayin[objects.inv].tsxand[favicon.ico].tsx— Newer@types/nodeno longer allowsBufferas aBodyInitargument tonew Response(). Wrapping withnew Uint8Array()is the correct fix sinceUint8ArraysatisfiesBufferSourcewhich is part ofBodyInit.Verification
Both
npm run compileandnpm run prod:buildpass cleanly after these changes.