test: Combine tests with _max_list_lenghts_by_column#23
Open
Marius Merkle (MariusMerkleQC) wants to merge 5 commits intonested_list_comparisonfrom
Open
test: Combine tests with _max_list_lenghts_by_column#23Marius Merkle (MariusMerkleQC) wants to merge 5 commits intonested_list_comparisonfrom
_max_list_lenghts_by_column#23Marius Merkle (MariusMerkleQC) wants to merge 5 commits intonested_list_comparisonfrom
Conversation
_max_list_lenghts_by_column_max_list_lenghts_by_column
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nested_list_comparison #23 +/- ##
========================================================
Coverage 100.00% 100.00%
========================================================
Files 10 10
Lines 759 759
========================================================
Hits 759 759 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot started reviewing on behalf of
Marius Merkle (MariusMerkleQC)
March 27, 2026 08:55
View session
There was a problem hiding this comment.
Pull request overview
Updates the condition-equality tests to derive tolerances and computed max_list_length values from DataFrameComparison (via compare_frames), and asserts the computed _max_list_lengths_by_column to validate the list-length inference logic introduced in #21.
Changes:
- Instantiate a
DataFrameComparisonin each relevant test usingcompare_frames. - Use the comparison object’s per-column tolerances and
_max_list_lengths_by_columnwhen callingcondition_equal_columns. - Add assertions validating
_max_list_lengths_by_columnfor each scenario (lists, nested lists, empty lists, non-list cases).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We hypothesize values for
max_list_lengthin #21 without asserting their correctness. Instead of adding separate tests with the same underlying set of data frames, I suggest asserting the values of_max_list_lenghts_by_columnwithin the same tests.Changes
test_conditions.py,DataFrameComparisonobject, andmax_list_lengthfrom the theDataFrameComparisonobject_max_list_lenghts_by_columnat the end