Skip to content

test: Combine tests with _max_list_lenghts_by_column#23

Open
Marius Merkle (MariusMerkleQC) wants to merge 5 commits intonested_list_comparisonfrom
combine_tests
Open

test: Combine tests with _max_list_lenghts_by_column#23
Marius Merkle (MariusMerkleQC) wants to merge 5 commits intonested_list_comparisonfrom
combine_tests

Conversation

@MariusMerkleQC
Copy link
Collaborator

@MariusMerkleQC Marius Merkle (MariusMerkleQC) commented Mar 27, 2026

Motivation

We hypothesize values for max_list_length in #21 without asserting their correctness. Instead of adding separate tests with the same underlying set of data frames, I suggest asserting the values of _max_list_lenghts_by_column within the same tests.

Changes

  • For each test in test_conditions.py,
    • Initialize a DataFrameComparison object, and
    • take absolute, relative, and absolute temporal tolerances, as well as max_list_length from the the DataFrameComparison object
    • assert values of _max_list_lenghts_by_column at the end

@MariusMerkleQC Marius Merkle (MariusMerkleQC) changed the base branch from main to nested_list_comparison March 27, 2026 08:26
@MariusMerkleQC Marius Merkle (MariusMerkleQC) changed the title tests: Combine tests with _max_list_lenghts_by_column test: Combine tests with _max_list_lenghts_by_column Mar 27, 2026
@codecov
Copy link

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3d5467a) to head (8a63395).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           nested_list_comparison       #23   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
========================================================
  Files                          10        10           
  Lines                         759       759           
========================================================
  Hits                          759       759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the condition-equality tests to derive tolerances and computed max_list_length values from DataFrameComparison (via compare_frames), and asserts the computed _max_list_lengths_by_column to validate the list-length inference logic introduced in #21.

Changes:

  • Instantiate a DataFrameComparison in each relevant test using compare_frames.
  • Use the comparison object’s per-column tolerances and _max_list_lengths_by_column when calling condition_equal_columns.
  • Add assertions validating _max_list_lengths_by_column for each scenario (lists, nested lists, empty lists, non-list cases).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly perform floating point comparisons for structs and lists

2 participants