You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Throw an error with better description what is failing
example:
Error: Code(Q44): Materialization error: Expected a text or element after
1 + 2 = 3
at location /some/file/location.tsx:123:1
metadata: {B`6=5|q:type|S}D{B`7=16|q:type|S}D{B`8=11|q:type|S}2,
value: 50,
next id: 52
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Great, but actually the location is unreadable without training. Since it's dev mode, can't we log the actual element so that when you hover it in the console you can see it highlighted on the page?
Great, but actually the location is unreadable without training. Since it's dev mode, can't we log the actual element so that when you hover it in the console you can see it highlighted on the page?
The problem is qerrors supports only strings. I am thinking if it should be a QError at all, maybe not
Thanks Michal!
What about changing "materialization" to "Resuming" or "Resumability" ?
reason: we teach about resumability but nobody knows yet what materialization means (and it's yet another term we need to teach about). So I think this will help keeping it simpler for us and for Qwik devs.
Plus adding a link to a doc that explains this error in more depth with possible fixes would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw an error with better description what is failing
example:
This also fixes dev location for CSR rendering