Adding past inputs to MultiHeadAttention parser for supporting new models#4703
Merged
Adding past inputs to MultiHeadAttention parser for supporting new models#4703
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4703 +/- ##
===========================================
+ Coverage 92.32% 92.34% +0.01%
===========================================
Files 583 583
Lines 29334 29412 +78
===========================================
+ Hits 27082 27158 +76
- Misses 2252 2254 +2
🚀 New features to boost your workflow:
|
TedThemistokleous
requested changes
Mar 27, 2026
Collaborator
There was a problem hiding this comment.
Overall looks good.
- Good comments explaining logic (gen_onnx test cases, early returns)
Just add the following
- Leverage
std::optionalfor capturing the argument after you've validated that all past input are good. This will simplify your checks and not rely on size of args - Add a small blub for your verify tests on how you generated the gold data in a comment box. Good for reproduction if we somehow see a regression with some other MIGraphX change.
Collaborator
Author
|
@TedThemistokleous |
kahmed10
approved these changes
Mar 31, 2026
Collaborator
Author
|
Can we merge this if everything is okay now? Thanks |
TedThemistokleous
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR has been created from this original PR: #4637
Motivation for this is support more input in MultiHeadAttention parser in order to support new VLM models.
Technical Details
Past key, past value and past_sequence_length have been added as new inputs that MultiHeadAttention supports.
Tests have been added for these new inputs.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable