Skip to content

[AIMIGRAPHX-840] support symbolic shape prop through conv and pool#4704

Draft
shivadbhavsar wants to merge 15 commits intosym_shape_methodsfrom
sym_conv_pool_shapes
Draft

[AIMIGRAPHX-840] support symbolic shape prop through conv and pool#4704
shivadbhavsar wants to merge 15 commits intosym_shape_methodsfrom
sym_conv_pool_shapes

Conversation

@shivadbhavsar
Copy link
Copy Markdown
Contributor

Motivation

Rewrite shape computation for convolution and pooling to work using dynamic dimension arithmetic using symbolic expressions. Works for both symbolic representation and pure range based representation.

Technical Details

Refer to section 7 in https://github.com/ROCm/AMDMIGraphX-internal/discussions/237

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

@shivadbhavsar shivadbhavsar self-assigned this Mar 25, 2026
@shivadbhavsar shivadbhavsar changed the title support symbolic shape prop through conv and pool [AIMIGRAPHX-840] support symbolic shape prop through conv and pool Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           sym_shape_methods    #4704      +/-   ##
=====================================================
- Coverage              92.51%   92.48%   -0.03%     
=====================================================
  Files                    583      583              
  Lines                  29872    29640     -232     
=====================================================
- Hits                   27634    27410     -224     
+ Misses                  2238     2230       -8     
Files with missing lines Coverage Δ
src/include/migraphx/op/convolution.hpp 96.59% <100.00%> (+1.85%) ⬆️
src/include/migraphx/op/pooling.hpp 93.79% <100.00%> (+0.26%) ⬆️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shivadbhavsar shivadbhavsar changed the base branch from sym_dim_integration to sym_shape_methods April 13, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants