Skip to content

[Misc] Propagate signatures through expr decorators - #835

Merged
coderfeli merged 7 commits into
ROCm:mainfrom
simondanielsson:feature/propagate-param-types
Jul 14, 2026
Merged

[Misc] Propagate signatures through expr decorators#835
coderfeli merged 7 commits into
ROCm:mainfrom
simondanielsson:feature/propagate-param-types

Conversation

@simondanielsson

@simondanielsson simondanielsson commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Motivation

Fixes #836.

This allows editors to show correct signatures of expressions rather than generic wrapper(*args, **kwargs) upon hover. This makes learning and using the DSL easier as it becomes more clear how to call expr functions.

Examples

  1. Before:
Screenshot 2026-07-12 155244

With this PR: more clear how to call this function.

Screenshot 2026-07-12 155346
  1. Before:
Screenshot 2026-07-12 161147

With this PR:

Screenshot 2026-07-12 161113

Technical Details

No runtime effect.

Test Plan

On MI300:

bash scripts/run_tests.sh    

Test Result

...
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======== 1325 passed, 2089 skipped, 934 deselected, 91 warnings in 687.01s (0:11:27) =========
acc=4
a=3 b=97
i=0
i=1
i=2
acc=4
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
[smem_probe] tid=0
kernel loop_count=1
helper i=0
kernel loop_count=4
helper i=0
helper i=1
helper i=2
helper i=3
kernel loop_count=8
helper i=0
helper i=1
helper i=2
helper i=3
helper i=4
helper i=5
helper i=6
helper i=7
[kernel] bid=0, tid=0
[kernel] bid=0, tid=1
[kernel] bid=0, tid=2

========================================================================
Examples (examples/)
========================================================================
  PASS  01-vectorAdd.py
  PASS  02-tiledCopy.py
  PASS  03-tiledMma.py
  PASS  04-preshuffle_gemm.py
  PASS  05-gather_scatter.py

========================================================================
MLIR FileCheck Tests
========================================================================
  PASS  Conversion/buffer_copy_lds.mlir
  PASS  Conversion/copy_atom_stateful.mlir
  PASS  Conversion/dyn_shared.mlir
  PASS  Conversion/gpu_ops.mlir
  PASS  Conversion/memref_ops.mlir
  PASS  Conversion/mma_atom.mlir
  PASS  Conversion/mma_atom_stateful.mlir
  PASS  Conversion/pointer_ops.mlir
  PASS  Conversion/type_conversion.mlir
  PASS  Conversion/wmma_gfx11.mlir
  PASS  Conversion/wmma_gfx11_neg.mlir
  PASS  LayoutAlgebra/coalesce.mlir
  PASS  LayoutAlgebra/composition.mlir
  PASS  LayoutAlgebra/construction.mlir
  PASS  LayoutAlgebra/coord_swizzle.mlir
  PASS  LayoutAlgebra/coordinate.mlir
  PASS  LayoutAlgebra/divide.mlir
  PASS  LayoutAlgebra/int_tuple.mlir
  PASS  LayoutAlgebra/mma_make_fragment_stages.mlir
  PASS  LayoutAlgebra/product.mlir
  PASS  LayoutAlgebra/size_cosize.mlir
  PASS  Transforms/canonicalize.mlir
  PASS  Transforms/convert-atom-call-to-ssa-form.mlir
  PASS  Transforms/expand_copy_reduced_pred.mlir
  PASS  Transforms/int_swizzle_simplify.mlir
  PASS  Transforms/layout_lowering.mlir
  PASS  Transforms/promote_regmem_to_ssa.mlir
  PASS  Transforms/promote_regmem_to_ssa_copy_pred.mlir
  PASS  Transforms/promote_regmem_to_ssa_invalid.mlir
  PASS  Transforms/rewrite_func_signature.mlir

========================================================================
All tests passed.
========================================================================

Submission Checklist

Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
@simondanielsson simondanielsson changed the title [Misc] Propagate param types in decorators for better user experience [Misc] Propagate param types in decorators Jul 12, 2026
@simondanielsson
simondanielsson marked this pull request as ready for review July 12, 2026 14:25
@simondanielsson simondanielsson changed the title [Misc] Propagate param types in decorators [Misc] Propagate signature through expr decorators Jul 12, 2026
@simondanielsson simondanielsson changed the title [Misc] Propagate signature through expr decorators [Misc] Propagate signatures through expr decorators Jul 12, 2026
@simondanielsson

Copy link
Copy Markdown
Contributor Author

@sjfeng1999 CI errors look unrelated, you could please take a look? Thanks

@coderfeli
coderfeli merged commit fa4f8ae into ROCm:main Jul 14, 2026
8 of 9 checks passed
@simondanielsson
simondanielsson deleted the feature/propagate-param-types branch July 14, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Function signatures not showing properly

3 participants