Repository navigation
Conversation
This means we can tell when a 413 error was returned, record it and use it to show our own error message.
Limited to 413 errors at the moment.
mwtrew
marked this pull request as ready for review
October 21, 2026 13:33
Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an error modal that's shown when the project fails to save due to an oversized asset. The modal tells the user that they need to remove the asset, and that saving the project will not be possible until they do so.
Implementation
Scratch's
onShowAlertdoesn't receive any information about why the save failed, so this approach patches Scratch'sstorage.storein order to be able to save error details to Redux at the time the upload fails. That allows us to determine whether the alert was caused by an oversized asset failing to upload, and show our error message accordingly.Considerations