Skip to content

use yaml struct to return n_read var #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 3 commits into from
Jan 9, 2026
+4 −2
Merged

use yaml struct to return n_read var #7579

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c2089d
use yaml struct to pass n_read
ben-schwen Jan 9, 2026
4e047bb
add test
ben-schwen Jan 9, 2026
8c01c72
remove unnecessary test
ben-schwen Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions R/fread.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ yaml=FALSE, tmpdir=tempdir(), tz="UTC")
call_args = names(match.call())
if (is.character(skip))
warningf("Combining a search string as 'skip' and reading a YAML header may not work as expected -- currently, reading will proceed to search for 'skip' from the beginning of the file, NOT from the end of the metadata; please file an issue on GitHub if you'd like to see more intuitive behavior supported.")
yaml_header = .read_yaml_header(input, skip, verbose)
yaml_res = .read_yaml_header(input, skip, verbose)
yaml_header = yaml_res$yaml_header
n_read = yaml_res$n_read
yaml_names = names(yaml_header)
# process header first since it impacts how to handle colClasses
if ('header' %chin% yaml_names) {
Expand Down Expand Up @@ -387,7 +389,7 @@ yaml=FALSE, tmpdir=tempdir(), tz="UTC")

yaml_header = yaml::yaml.load(yaml_string)
if (verbose) catf('Processed %d lines of YAML metadata with the following top-level fields: %s\n', n_read, brackify(names(yaml_header)))
yaml_header
list(yaml_header = yaml_header, n_read = n_read)
}
# nocov end.

Expand Down
Loading