fix: populate package repository metadata - #150
Merged
baszalmstra merged 1 commit intoSep 4, 2026
Conversation
baszalmstra
force-pushed
the
fix/populate-package-repository
branch
4 times, most recently
from
September 4, 2026 10:42
d2bab49 to
829bdaf
Compare
baszalmstra
marked this pull request as ready for review
September 4, 2026 12:15
baszalmstra
force-pushed
the
fix/populate-package-repository
branch
from
September 4, 2026 12:23
829bdaf to
631d64a
Compare
traversaro
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
about.repositoryis often missing from generated ROS recipes. This selects it in this order:repositorysource_repository, unless it is a Bloom release repository<url type="repository">valueRepository URLs are stored without the
.gitsuffix. Source-download URLs and Bloom release repositories are not treated as upstream identity. Snapshots preserve the selected URL. Homepage, license, and summary metadata continue to come from the package manifest.Audit
Generating all 1,551 Linux recipes from
RoboStack/ros-rollingproduced 557 changes:The baseline contained 220 manifest repository URLs. The fallback keeps them when rosdistro has no usable source repository, including these reviewed cases:
ros-planning/moveit2. GitHub redirects that path to the canonicalmoveit/moveit2repository. Consumers should resolve GitHub redirects and use the API'sfull_namerather than deriving an owner and name from the URL text.mavlink/mavlink-gbp-release. That Bloom repository is rejected, so the manifest'smavlink/mavlinkrepository is retained.Full
about.repositorycomparisonTesting
pixi run pytest vinca/test_snapshot_metadata.py vinca/test_recipes.py(34 passed)pixi run ruff check vinca/distro.py vinca/main.py vinca/recipes.py vinca/test_snapshot_metadata.py vinca/test_recipes.pypixi run pyrefly check vinca/distro.py vinca/main.py vinca/recipes.py vinca/test_snapshot_metadata.py vinca/test_recipes.pyskip_existingdisabled