chore: remove diffEnabled and fuzzyMatchThreshold settings #10298
Conversation
Native tool calling makes these controls obsolete. Removes: - diffEnabled and fuzzyMatchThreshold from provider settings types - DiffSettingsControl UI component - Related translations from all 18 locale files - System prompt diffEnabled parameter - Conditional apply_diff tool filtering based on diffEnabled - Associated tests and migrations
dosubot
bot
added
the
size:L
Re-review complete. No new issues found in commits since the last review.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
packages/types/src/task.ts
Outdated
| */ | ||
|
|
||
| export interface CreateTaskOptions { | ||
| enableDiff?: boolean |
There was a problem hiding this comment.
enableDiff is still exposed in CreateTaskOptions, but it no longer affects runtime behavior now that Task always initializes a diff strategy. Keeping this flag makes the API misleading (callers can set it but nothing changes), so it seems better to remove or explicitly deprecate it.
Fix it with Roo Code or mention @roomote and request a fix.
packages/types/src/task.ts
Outdated
| */ | ||
|
|
||
| export interface CreateTaskOptions { | ||
| enableDiff?: boolean |
There was a problem hiding this comment.
CreateTaskOptions.enableDiff still exists in the public types, but this PR makes diff strategy initialization unconditional, so this flag becomes a no-op for consumers. That mismatch can lead to confusing integrations where callers think they can disable diffs.
| enableDiff?: boolean | |
| /** @deprecated Diff editing is always enabled; this flag is ignored. */ | |
| enableDiff?: boolean |
Fix it with Roo Code or mention @roomote and request a fix.
Remove enableDiff property from public CreateTaskOptions interface since diffs are now always enabled. This addresses the review feedback to clean up the no-op property. - Remove enableDiff from packages/types/src/task.ts - Remove enableDiff usage from test file
Summary
Removes the "Enable editing through diffs" (
diffEnabled) and "Match precision" (fuzzyMatchThreshold) settings from Roo Code. Native tool calling makes these controls obsolete.Changes
diffEnabledandfuzzyMatchThresholdfrom provider settings types (provider-settings.ts,global-settings.ts,task.ts,cloud.ts)DiffSettingsControl.tsxUI component entirelydiffEnabledparameter fromSYSTEM_PROMPT()function signatureapply_difftool exclusion fromfilter-tools-for-mode.tsdiffEnabledmigration fromProviderSettingsManager.tssetDiffEnabledfromExtensionStateContext.tsxdiffEnabled,diffEnabledDescription,matchPrecision, andmatchPrecisionDescriptiontranslations from all 18 locale filessystem-prompt.spec.ts,Task.spec.ts,ClineProvider.spec.ts, andApiOptions.spec.tsxImportant
Remove obsolete
diffEnabledandfuzzyMatchThresholdsettings from configuration, UI, and tests, and update translations.diffEnabledandfuzzyMatchThresholdfromprovider-settings.ts,global-settings.ts,task.ts,cloud.ts.DiffSettingsControl.tsxcomponent.diffEnabledparameter fromSYSTEM_PROMPT()function.diffEnabledmigration fromProviderSettingsManager.ts.setDiffEnabledfromExtensionStateContext.tsx.diffEnabled,diffEnabledDescription,matchPrecision,matchPrecisionDescriptionfrom all 18 locale files.system-prompt.spec.ts,Task.spec.ts,ClineProvider.spec.ts,ApiOptions.spec.tsxto reflect removal of settings.This description was created by
for 2c6ed92. You can customize this summary. It will automatically update as commits are pushed.