-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ux: Provider-centric signup #10306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ux: Provider-centric signup #10306
+1,099
−432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
All issues have been resolved. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx
Show resolved
Hide resolved
webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx
Outdated
Show resolved
Hide resolved
…r.spec.tsx Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
…r.spec.tsx Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
- Add missing TriangleAlert icon to lucide-react mock - Update test assertions to match new component structure - Replace references to 'rooCloudProvider' heading with 'greeting' - Update 'Use Roo Code Provider' to 'backToRoo' translation key - All 9 tests now passing
webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx
Show resolved
Hide resolved
webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx
Outdated
Show resolved
Hide resolved
…r.spec.tsx Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
…r.spec.tsx Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Contributor
All issues have been resolved. Tests pass.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
mrubens
approved these changes
Dec 23, 2025
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
…hout model selection When a user signs up via Roo Code Cloud but doesn't select a provider model during the signup flow, they should be taken to the provider selection screen with '3rd-party Provider' pre-selected instead of automatically being configured with the Roo provider. Changes: - WebAuthService: Store roo-auth-skip-model flag when providerModel is not provided - ExtensionState: Add cloudAuthSkipModel field to pass flag to webview - ClineProvider: Read and pass the flag to webview state - WebviewMessage: Add clearCloudAuthSkipModel message type - webviewMessageHandler: Add handler to clear the flag - WelcomeViewProvider: Check flag on auth completion and navigate to custom provider selection - Tests: Add test for skip model flag behavior
mrubens
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue/PR - Triage
New issue. Needs quick review to confirm validity and assign labels.
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
UI/UX
UI/UX related or focused
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering adoption and how much easier it is to get started with the Roo provider, this makes it the default path, while still leaving other providers as a secondary option. Plus other UX niceties.
Important
Enhances signup UX by defaulting to Roo provider, adds UI improvements, and updates translations.
roo-auth-skip-modelinWebAuthService.tsto handle cases where no model is selected during signup.WelcomeViewProvider.tsxto include a landing screen and provider selection screen.RooHero.tsx.ApiOptions.tsxto filter out Roo provider on the welcome screen.WelcomeViewProvider.spec.tsxto cover new signup flow and UI changes.ground-slideandsuninindex.css.This description was created by
for 99f2e72. You can customize this summary. It will automatically update as commits are pushed.