fix: sanitize tool_use_id in tool_result blocks to match API history

[daniel-lxs]

Summary

Fixes ToolResultIdMismatchError where tool_result IDs didn't match tool_use IDs in API conversation history.

Problem

PostHog reported 926 ToolResultIdMismatchError occurrences in v3.46.0 where tool_result IDs (e.g., functions.read_file:0) didn't match tool_use IDs (e.g., functions_read_file_0).

Root Cause

In Task.ts, when saving tool_use blocks to API conversation history, IDs were sanitized using sanitizeToolUseId(). However, in presentAssistantMessage.ts, when creating tool_result blocks, the original unsanitized toolCallId was used.

Solution

Updated presentAssistantMessage.ts to sanitize toolCallId using sanitizeToolUseId() when creating tool_result blocks, ensuring consistency with how tool_use IDs are stored in history.

Changes

• Added import for sanitizeToolUseId in presentAssistantMessage.ts
• Updated all 7 occurrences of tool_use_id: toolCallId to tool_use_id: sanitizeToolUseId(toolCallId)
• Added test case for the exact pattern seen in PostHog

Testing

• All existing tests pass (5317 tests)
• Added test case verifying functions.read_file:0 → functions_read_file_0 sanitization

Linear Issue

Fixes EXT-711

---

Important

Fixes ToolResultIdMismatchError by sanitizing toolCallId in presentAssistantMessage.ts to ensure consistent ID format.

• Behavior:
  • Fixes ToolResultIdMismatchError by sanitizing toolCallId in presentAssistantMessage.ts using sanitizeToolUseId().
  • Ensures tool_result IDs match tool_use IDs in API history.
• Testing:
  • Adds test case in tool-id.spec.ts for sanitizing functions.read_file:0 to functions_read_file_0.
  • Confirms all existing tests pass (5317 tests).

^{This description was created by for fe85422. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review complete. No issues found.

The fix correctly addresses the ToolResultIdMismatchError by ensuring tool_result IDs are sanitized to match the sanitized tool_use IDs in API history. All 7 occurrences are updated consistently, and the test coverage is appropriate.

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}