Fix delegate return type: byte* instead of string for const char*#336
Merged
Fix delegate return type: byte* instead of string for const char*#336
Conversation
Fixes #271 - Delegates (function pointers in structs like AVClass.item_name) incorrectly used string return type for const char*. String marshaling does not work with unmanaged function pointers, causing AccessViolationException. Changed generator to emit byte* for delegate return types when the C function returns const char*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVClass_item_namenow correctly returnbyte*instead ofstringforconst char*C functionsAccessViolationExceptionFixes #271
Test plan