Adds a builder for configuring outputstreams #815
Conversation
yara-blue
force-pushed
the
output-builder
branch
from
40c2732 to
1e4dbbe
Compare
roderickvd
left a comment
roderickvd
left a comment
There was a problem hiding this comment.
In RustAudio/cpal#956 I was also toying around with the idea of a StreamConfigBuilder - let me know how we can align those efforts!
|
As for naming, here are some suggestions:
If we want to use Source → Stream → Sink terminology (pretty accurate actually) then to disambiguate we should rename the existing Sink to something like MixerQueue, AudioQueue, or QueuedOutput. |
Its basically the same as the microphone builder. It will replace the OutputStream. In the future we'll add more abstractions on top. Until its done it lives under an experimental flag. Names are subject to change too, Speakers is probably not ideal but it conveys the meaning better then OutputStream. I'm thinking of having a Source -> Stream -> Sink terminolgy where a Sink could be the audio card, the network or a file (the wavwriter).
yara-blue
force-pushed
the
output-builder
branch
from
d717a09 to
6497d03
Compare
yara-blue
force-pushed
the
output-builder
branch
from
d611318 to
2da8f49
Compare
Agreed, we should. Sink would be the perfect name for this "concept". We can have a file sink as well (the current Its already pretty big. Makes sense to land it as is and then tweak as I use it. The next thing I'd like to add after this is a new Hit that merge button if you think we can get it in. |
roderickvd
left a comment
roderickvd
left a comment
There was a problem hiding this comment.
I found a few last points.
|
Thanks for the review, should be good to merge now :) |
Its basically the same as the microphone builder. It will replace the OutputStream. In the future we'll add more abstractions on top. Until its done it lives under an experimental flag.
Names are subject to change too, Speakers is probably not ideal but it conveys the meaning better then OutputStream. I'm thinking of having a Source -> Stream -> Sink terminolgy where a Sink could be the audio card, the network or a file (the wavwriter).