The ct_eq_bytes method produces an invalid Choice#261
Open
rot256 wants to merge 1 commit intoRustCrypto:masterfrom
Open
The ct_eq_bytes method produces an invalid Choice#261rot256 wants to merge 1 commit intoRustCrypto:masterfrom
ct_eq_bytes method produces an invalid Choice#261rot256 wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
ee92617 to
0b2a5b4
Compare
Member
|
That entire function looks like it could be replace with the |
Contributor
Author
|
Yea, that's the better idea. |
0b2a5b4 to
c7f7f2f
Compare
c7f7f2f to
60753ab
Compare
Contributor
Author
|
Got rid of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to just pick the fix commit, in case you don't want the regression test.
The test fails with: