Skip to content

digest: remove impl of subtle::ConstantTimeEq for CtOutput #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 2 commits into from
Feb 9, 2026
Merged

digest: remove impl of subtle::ConstantTimeEq for CtOutput #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff257ee
digest: remove impl of `subtle::ConstantTimeEq` for `CtOutput`
newpavlov Feb 9, 2026
3fa9d3b
Update changelog
newpavlov Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions digest/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `HashReader` and `HashWriter` are moved to the `digest-io` crate ([#1809])
- `io::Write/Read` implementations in favor of the `digest_io::IoWrapper` type ([#1809])
- `VariableOutput` trait ([#2043])
- Implementation of `subtle::ConstantTimeEq` for `CtOutput`. Note that implementation of
`PartialEq`/`Eq` trait is still const time. ([#2292])

[#1173]: https://github.com/RustCrypto/traits/pull/1173
[#1334]: https://github.com/RustCrypto/traits/pull/1334
Expand All @@ -38,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#1958]: https://github.com/RustCrypto/traits/pull/1958
[#2043]: https://github.com/RustCrypto/traits/pull/2043
[#2237]: https://github.com/RustCrypto/traits/pull/2237
[#2292]: https://github.com/RustCrypto/traits/pull/2292

## 0.10.7 (2023-05-19)
### Changed
Expand Down
13 changes: 3 additions & 10 deletions digest/src/mac.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use common::{Output, OutputSizeUser, Reset};

use common::typenum::Unsigned;
use core::fmt;
use subtle::{Choice, ConstantTimeEq};
use subtle::ConstantTimeEq;

/// Marker trait for Message Authentication algorithms.
pub trait MacMarker {}
Expand Down Expand Up @@ -215,17 +215,10 @@ impl<'a, T: OutputSizeUser> From<&'a Output<T>> for CtOutput<T> {
}
}

impl<T: OutputSizeUser> ConstantTimeEq for CtOutput<T> {
#[inline(always)]
fn ct_eq(&self, other: &Self) -> Choice {
self.bytes.ct_eq(&other.bytes)
}
}

impl<T: OutputSizeUser> PartialEq for CtOutput<T> {
#[inline(always)]
fn eq(&self, x: &CtOutput<T>) -> bool {
self.ct_eq(x).into()
fn eq(&self, other: &CtOutput<T>) -> bool {
self.bytes.ct_eq(&other.bytes).into()
}
}

Expand Down