Skip to content

SoC Timestamp support for openWB#380

Open
tosate wants to merge 5 commits intoSAIC-iSmart-API:developfrom
tosate:feat/openwb_ts
Open

SoC Timestamp support for openWB#380
tosate wants to merge 5 commits intoSAIC-iSmart-API:developfrom
tosate:feat/openwb_ts

Conversation

@tosate
Copy link
Contributor

@tosate tosate commented Oct 6, 2025

Fix for Issue #378: Add support for soc_timestamp topic for openWB

Copy link
Contributor

@nanomad nanomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tosate, thanks for this PR! Could you rebase it onto the latest main branch? It's currently showing conflicts.

Also, one issue found during review:

SoC timestamp published even when SoC is None
The timestamp block at the end of update_openwb runs independently of whether SoC was actually published. If soc is None, openWB would still receive a fresh timestamp, misleading it into thinking the SoC was just updated. The fix is to nest the timestamp publishing inside the existing if soc is not None and soc_topic is not None guard.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants