SoC Timestamp support for openWB#380
Open
tosate wants to merge 5 commits intoSAIC-iSmart-API:developfrom
Open
Conversation
nanomad
reviewed
Mar 10, 2026
Contributor
nanomad
left a comment
There was a problem hiding this comment.
Hi @tosate, thanks for this PR! Could you rebase it onto the latest main branch? It's currently showing conflicts.
Also, one issue found during review:
SoC timestamp published even when SoC is None
The timestamp block at the end of update_openwb runs independently of whether SoC was actually published. If soc is None, openWB would still receive a fresh timestamp, misleading it into thinking the SoC was just updated. The fix is to nest the timestamp publishing inside the existing if soc is not None and soc_topic is not None guard.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #378: Add support for
soc_timestamptopic for openWB