feat(shellhook): detect active shell and auto-create profile on tip install#17
Merged
jung-thomas merged 2 commits intomainfrom May 7, 2026
Merged
feat(shellhook): detect active shell and auto-create profile on tip install#17jung-thomas merged 2 commits intomainfrom
jung-thomas merged 2 commits intomainfrom
Conversation
…nstall On Windows, PowerShell profiles don't exist by default so `tip install` would only configure Git Bash profiles. Now detects the active shell via environment heuristics (PSModulePath for PowerShell, SHELL for bash/zsh) and creates the corresponding profile file before writing the hook.
Tests that simulate Windows PowerShell or Linux Zsh now override the new `currentOS` package variable so candidateProfiles() generates the correct platform paths regardless of the CI runner's actual GOOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tip install~/Documents/PowerShell/Microsoft.PowerShell_profile.ps1doesn't exist by defaultTest plan
sap-devs tip installin PowerShell on a machine without an existing PS profile — verify the profile is created and hook is writtensap-devs tip installin Zsh/Bash — verify the detected shell's rc file is created if missingsap-devs tip installwhen hook is already present — verify idempotent (no duplicate)sap-devs tip uninstall— verify removal still works (no changes to Remove path)go test ./internal/shellhook/...passes (14 new test cases covering detection, creation, and edge cases)