Skip to content

Remove extension name and tool prefix as Input args #115

Draft
mudit777 wants to merge 2 commits into
SAP:mainfrom
mudit777:main
Draft

Remove extension name and tool prefix as Input args #115
mudit777 wants to merge 2 commits into
SAP:mainfrom
mudit777:main

Conversation

@mudit777
Copy link
Copy Markdown
Contributor

@mudit777 mudit777 commented May 12, 2026

Disclaimer: Do not include SAP-internal or customer-specific information in this PR (e.g. internal system URLs, customer names, tenant IDs, or confidential configurations). This is a public repository.

Description

Simplify call_extension_tool() signature by removing the extension_name and tool_prefix parameters. The tool_name argument is now used directly as the lookup key in source_mapping (no more prefix reconstruction), and the fallback extension name defaults to unknown internally via resolve_source_info().

Related Issue

Closes #<issue_number>

(Link to the GitHub issue this PR addresses)

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

Describe how reviewers can test your changes:

  1. Run the telemetry extension unit tests: pytest tests/core/unit/telemetry/test_extensions.py -v
  2. Run the full unit test suite: pytest tests/ --ignore-glob='**/integration*'
  3. All 58 telemetry extension tests and 2007 total unit tests should pass.

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Breaking Changes

If this PR introduces breaking changes, please describe:

  • What breaks: Callers of call_extension_tool() that pass extension_name or tool_prefix keyword arguments will get a TypeError at runtime.
  • Migration path for users:
    • Remove the extension_name parameter — the extension name is now resolved internally from source_mapping, falling back to "unknown".
    • Remove the tool_prefix parameter — pass the full tool name (already prefixed if applicable) as tool_name directly.
    • Ensure source_mapping keys match the tool_name values being passed (i.e., use the final tool name, not the unprefixed version).
  • Alternative approaches considered: Keeping extension_name as an optional fallback, but "unknown" is sufficient since source_mapping already provides the correct name in all practical cases.

Additional Notes

Downstream consumers need corresponding updates to remove extension_name and tool_prefix from their call_extension_tool() call sites

@mudit777 mudit777 requested a review from a team as a code owner May 12, 2026 21:51
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented May 12, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mudit777 mudit777 marked this pull request as draft May 13, 2026 06:27
@mudit777 mudit777 changed the title 🔥 clean up Remove extension name and tool prefix as Input args May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant