Skip to content

fix(agent-memory): rename BindingData.url to application_url#117

Merged
cassiofariasmachado merged 1 commit into
SAP:mainfrom
santoshnallur-sap:fix/agent-memory-url
May 13, 2026
Merged

fix(agent-memory): rename BindingData.url to application_url#117
cassiofariasmachado merged 1 commit into
SAP:mainfrom
santoshnallur-sap:fix/agent-memory-url

Conversation

@santoshnallur-sap
Copy link
Copy Markdown
Contributor

@santoshnallur-sap santoshnallur-sap commented May 13, 2026

Description

The BTP service binding for hana-agent-memory mounts the service URL under
the key application_url, not url. The previous implementation used url
as the field name in BindingData, which caused the secret resolver to look
for the wrong mount file and generate the wrong environment variable name.

What changed:

  • BindingData.url renamed to BindingData.application_url
  • Mount path is now correctly resolved to:
    /etc/secrets/appfnd/hana-agent-memory/default/application_url
  • Environment variable name corrected to:
    CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL
  • Updated user-guide, integration test docs, and example env file accordingly

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

How to Test

uv run pytest tests/agent_memory/unit/ -v

For integration tests, set the following in .env_integration_tests:

CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL=https://your-agent-memory-api-url
CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_UAA='{"url":"https://your-auth-url","clientid":"your-client-id","clientsecret":"your-client-secret"}'

Then run:

uv run pytest tests/agent_memory/integration/ -v

Checklist

  • My code follows the project's Code Guidelines
  • I have added type hints for all public APIs
  • I have added unit tests covering the new functionality
  • I have added or updated the user guide (user-guide.md) in the module directory
  • All existing tests pass locally
  • My commits follow Conventional Commits format
  • No confidential or SAP-internal information is included

Additional Notes

The field rename is internal to BindingData (a private dataclass) and has
no impact on the public AgentMemoryConfig API or any existing user code.
Users who were previously setting
CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_URL will need to rename it to
CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL.


Disclaimer: Do not include SAP-internal or customer-specific information in this PR. This is a public repository.

The BTP service binding mounts the service URL under the key application_url,
not url. Rename BindingData.url → application_url so the secret resolver maps
to the correct mount file and env var:

  /etc/secrets/appfnd/hana-agent-memory/default/application_url
  CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL

Update tests, user-guide, and example env files accordingly.
@santoshnallur-sap santoshnallur-sap marked this pull request as ready for review May 13, 2026 13:49
@santoshnallur-sap santoshnallur-sap requested a review from a team as a code owner May 13, 2026 13:49
@cassiofariasmachado cassiofariasmachado merged commit 1318392 into SAP:main May 13, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants