fix(agent-memory): rename BindingData.url to application_url#117
Merged
cassiofariasmachado merged 1 commit intoMay 13, 2026
Merged
Conversation
The BTP service binding mounts the service URL under the key application_url, not url. Rename BindingData.url → application_url so the secret resolver maps to the correct mount file and env var: /etc/secrets/appfnd/hana-agent-memory/default/application_url CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL Update tests, user-guide, and example env files accordingly.
cassiofariasmachado
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BTP service binding for
hana-agent-memorymounts the service URL underthe key
application_url, noturl. The previous implementation usedurlas the field name in
BindingData, which caused the secret resolver to lookfor the wrong mount file and generate the wrong environment variable name.
What changed:
BindingData.urlrenamed toBindingData.application_url/etc/secrets/appfnd/hana-agent-memory/default/application_urlCLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URLType of Change
How to Test
For integration tests, set the following in
.env_integration_tests:CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL=https://your-agent-memory-api-url CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_UAA='{"url":"https://your-auth-url","clientid":"your-client-id","clientsecret":"your-client-secret"}'Then run:
Checklist
user-guide.md) in the module directoryAdditional Notes
The field rename is internal to
BindingData(a private dataclass) and hasno impact on the public
AgentMemoryConfigAPI or any existing user code.Users who were previously setting
CLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_URLwill need to rename it toCLOUD_SDK_CFG_HANA_AGENT_MEMORY_DEFAULT_APPLICATION_URL.