Skip to content

feat(agentgateway): make timeout configurable and increase default timeout value#118

Merged
NicoleMGomes merged 9 commits into
SAP:mainfrom
prashantrakheja:impl-user-token-caching
May 15, 2026
Merged

feat(agentgateway): make timeout configurable and increase default timeout value#118
NicoleMGomes merged 9 commits into
SAP:mainfrom
prashantrakheja:impl-user-token-caching

Conversation

@prashantrakheja
Copy link
Copy Markdown
Contributor

@prashantrakheja prashantrakheja commented May 13, 2026

Description

Increases the timeout value to 60s as a more reasonable default.

The PR makes timeouts configurable for edge cases.

Also, added changes to unwrap ExceptionGroup from async task groups to surface meaningful error messages
(e.g., "MCP Builder destination request failed" instead of "unhandled errors in a TaskGroup")

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

Signed-off-by: Prashant <prashant.rakheja@sap.com>
Signed-off-by: Prashant <prashant.rakheja@sap.com>
@prashantrakheja prashantrakheja requested a review from a team as a code owner May 13, 2026 15:52
@prashantrakheja prashantrakheja changed the title feat(agentgateway): Make timeout configurable and increase default timeout value feat(agentgateway): make timeout configurable and increase default timeout value May 13, 2026
Signed-off-by: Prashant <prashant.rakheja@sap.com>
Signed-off-by: Prashant <prashant.rakheja@sap.com>
Comment thread src/sap_cloud_sdk/agentgateway/_lob.py Outdated
Signed-off-by: Prashant <prashant.rakheja@sap.com>
Comment thread src/sap_cloud_sdk/agentgateway/config.py Outdated
Signed-off-by: Prashant <prashant.rakheja@sap.com>
@NicoleMGomes NicoleMGomes merged commit 1c2e930 into SAP:main May 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants