feat(contrib): add PR review and module scaffold skills#131
Open
jeanscherf wants to merge 1 commit into
Open
Conversation
Adds two Claude Code skills to .claude/skills/ for SDK contributors: - review-pr: reviews a PR against 23 criteria across 6 sections (process, security, code quality, API design, tests, documentation). Runs from the repo root via gh CLI. Outputs a structured table report with verdict and optional gh pr review posting. - scaffold-module: generates the full standard module layout (10 files + telemetry wiring) for a new BTP service integration. Includes a self-review phase that runs ruff and fixes issues before reporting. Both skills are compatible with Claude Code, Cline, Copilot, and other agentic tools via the tools/compatibility frontmatter fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two Claude Code skills to
.claude/skills/for SDK contributors. Skills are invocable via Claude Code CLI (or any compatible agentic tool: Cline, Copilot, etc.) from the repo root./review-pr [PR#]Reviews a PR against 23 criteria across 6 sections:
Outputs a structured table report with ✅/⚠️ /❌/➖ per criterion, blocking issues summary, and optional posting via
gh pr review./scaffold-moduleGenerates the full standard module layout for a new BTP service integration:
__init__.py,client.py,config.py,exceptions.py,_models.py,py.typed,user-guide.md, plus test stubsModule.<NAME>intocore/telemetry/module.pyin alphabetical orderuv run ruff checkon generated files and fixes issues before reportingType of Change
How to Test
/review-pr 128— verify a structured 23-criterion report is produced/scaffold-moduleand provide test inputs (e.g. module=test_svc, service=Test Service, short=TS) — verify 10 files are generated, ruff passes, test passesChecklist
uv run ruff checkanduv run pytesttoolsandcompatibilityfrontmatter fields