refactor(secret-resolver)!: refactor to use constants for base path and env var prefix#97
Draft
cassiofariasmachado wants to merge 1 commit into
Draft
refactor(secret-resolver)!: refactor to use constants for base path and env var prefix#97cassiofariasmachado wants to merge 1 commit into
cassiofariasmachado wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorders
read_from_mount_and_fallback_to_env_varparameters somodule,instance, andtargetcome first, and makesbase_volume_mount/base_var_nameoptional kwargs with constant defaults.Related Issue
N/A
Type of Change
How to Test
uv run pytest -m "not integration" -qbase_volume_mountorbase_var_name:Checklist
Breaking Changes
read_from_mount_and_fallback_to_env_varparameter reorder: The first two positional parameters changed from(base_volume_mount, base_var_name, module, instance, target)to(module, instance, target, base_volume_mount=..., base_var_name=...). Any caller that used positional arguments must be updated.Migration: Update call sites to the new positional order, or switch to keyword arguments: