feat(audit): correlation id on notifications + notification_sent/fail…#13
Merged
Conversation
…ed audit (Story 13.7 Phase B gate #3) All notification payloads (Mail #21, SMS #20, Push #25, Ws #21) carry an optional correlation_id; the Notification trait exposes it (abstract def correlationId) plus a withCorrelationId wither, so producers thread the originating flow's id and the behavior reads it generically. NotificationBehavior.sendNotification emits a terminal audit line via the upstream AuditLog("notification") — notification_sent (Sent/Delivered) or notification_failed (Undelivered/Rejected) — only when an actual send/ack happened this round (skips deferred/no-op/Pending). audit is a lazy val (trait default method, no abstract setter → binary-compatible for implementers). Bumps genericPersistence -> 0.9-SNAPSHOT and notification version -> 0.9-SNAPSHOT. SimpleMailNotificationsHandlerSpec: +audit-line capture test (10 green); +compile (2.12+2.13) + scalafmtAll clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
- Coverage 71.39% 70.94% -0.45%
==========================================
Files 61 61
Lines 1115 1122 +7
Branches 169 178 +9
==========================================
Hits 796 796
- Misses 319 326 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed audit (Story 13.7 Phase B gate #3)
All notification payloads (Mail #21, SMS #20, Push #25, Ws #21) carry an optional correlation_id; the Notification trait exposes it (abstract def correlationId) plus a withCorrelationId wither, so producers thread the originating flow's id and the behavior reads it generically.
NotificationBehavior.sendNotification emits a terminal audit line via the upstream AuditLog("notification") — notification_sent (Sent/Delivered) or notification_failed (Undelivered/Rejected) — only when an actual send/ack happened this round (skips deferred/no-op/Pending). audit is a lazy val (trait default method, no abstract setter → binary-compatible for implementers).
Bumps genericPersistence -> 0.9-SNAPSHOT and notification version -> 0.9-SNAPSHOT. SimpleMailNotificationsHandlerSpec: +audit-line capture test (10 green); +compile (2.12+2.13) + scalafmtAll clean.