Skip to content

Comments

[SYNPY-1590] Add docker_commit_services module to codebase#1304

Merged
BryanFauble merged 3 commits intodevelopfrom
hotfix-submission-oop-tests
Jan 8, 2026
Merged

[SYNPY-1590] Add docker_commit_services module to codebase#1304
BryanFauble merged 3 commits intodevelopfrom
hotfix-submission-oop-tests

Conversation

@jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Jan 7, 2026

Problem:

Some unit tests for the Submission OOP were failing because the codebase was not exporting the docker_commit_services module and its get_docker_tag function and this module was not committed to the repository:

Example

=========================== short test summary info ============================
FAILED tests/unit/synapseclient/models/async/unit_test_submission_async.py::TestSubmissionAsync::test_fetch_latest_entity_docker_repository_async - AttributeError: module 'synapseclient.api' has no attribute 'docker_commit_services'
FAILED tests/unit/synapseclient/models/async/unit_test_submission_async.py::TestSubmissionAsync::test_fetch_latest_entity_docker_empty_results_async - AttributeError: module 'synapseclient.api' has no attribute 'docker_commit_services'
FAILED tests/unit/synapseclient/models/async/unit_test_submission_async.py::TestSubmissionAsync::test_fetch_latest_entity_docker_complex_tag_selection_async - AttributeError: module 'synapseclient.api' has no attribute 'docker_commit_services'
...
unit_test_submission.py::TestSubmission::test_fetch_latest_entity_docker_repository - AttributeError: module 'synapseclient.api' has no attribute 'docker_commit_services'
FAILED tests/unit/synapseclient/models/synchronous/unit_test_submission.py::TestSubmission::test_fetch_latest_entity_docker_empty_results - AttributeError: module 'synapseclient.api' has no attribute 'docker_commit_services'
FAILED tests/unit/synapseclient/models/synchronous/unit_test_submission.py::TestSubmission::test_fetch_latest_entity_docker_complex_tag_selection - AttributeError: module 'synapseclient.api' has no attribute 'docker_commit_services'
...

Solution:

Add docker_commit_services to repo and export its function on the relevant __init__.py

Testing:

async unit tests:
image

sync unit tests:
image

@jaymedina jaymedina changed the title [SYNPY-1590] Export docker_commit_services and get_docker_tag [SYNPY-1590] Add docker_commit_services module to codebase Jan 7, 2026
@jaymedina jaymedina marked this pull request as ready for review January 7, 2026 22:35
@jaymedina jaymedina requested a review from a team as a code owner January 7, 2026 22:35
Copy link
Member

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test failures were patched that this PR was created for. Other unit test failures are patched in develop, so I am going to just go ahead and merge this into develop.

@BryanFauble BryanFauble merged commit 2b44e52 into develop Jan 8, 2026
13 of 28 checks passed
@BryanFauble BryanFauble deleted the hotfix-submission-oop-tests branch January 8, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants