[SYNPY-1590] Patching the async generator to return results as it gets them, and removing param passing to several submission related APIs which do not support it#1305
Merged
BryanFauble merged 3 commits intodevelopfrom Jan 9, 2026
Conversation
…emoving param passing to several submission related APIs which do not support it
jaymedina
reviewed
Jan 8, 2026
jaymedina
reviewed
Jan 8, 2026
jaymedina
approved these changes
Jan 8, 2026
Contributor
jaymedina
left a comment
There was a problem hiding this comment.
thanks for the patch!
lg, but it's unclear to me what caused the infinite loop for those test cases as I wasn't able to reproduce the issue. it seems that with some of the parameters of the API services not being exposed, calls to these APIs would default to limit=10, offset=0, etc, so the generator wrapper would have grabbed a finite amount of submissions regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Testing: