Open
Conversation
This is a fix for Month headers not displaying properly. If you are in a different timezone than the org you are logging into, Intl.DateTimeFormat(.....) will add or subtract X hours from monthItem.firstOfMonth, where X is UTC-X. The result is that when we are setting month value for the header, the formatted value is January 31st instead of February 1st, for instance. There are several instances where this is happening in the file, but this is the most obvious and glaring one I tackled first. By creating a local date, and using that value instead we ensure the date displays properly.
|
Thanks for the contribution! Before we can merge this, we need @mchakotay to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
Signed the salesforce-CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for Month headers not displaying properly. If you are in a different timezone than the org you are logging into, Intl.DateTimeFormat(.....) will add or subtract X hours from monthItem.firstOfMonth, where X is UTC-X. The result is that when we are setting month value for the header, the formatted value is January 31st instead of February 1st, for instance. There are several instances where this is happening in the file, but this is the most obvious and glaring one I tackled first. By creating a local date, and using that value instead we ensure the date displays properly.