Add some plans (no app logic changed) - #548
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two architecture/implementation planning documents under docs/plan/, outlining (1) a unified multi-group graph with per-group visibility filtering and (2) a longer-term refactor to split logical layout (C++) from visual geometry/animation (QML). This fits the codebase by documenting future work in the GroupsManager/MainScene/model/QML layers without changing runtime behavior.
Changes:
- Added a step-by-step plan for merging all groups into one graph and introducing group visibility filters (model + QML UI).
- Added a phased migration plan to move pixel layout responsibility from C++ (
TermGroup) into QML while keeping logical topology in C++. - Documented target files/classes and suggested incremental verification points.
Testing:
- Not run (docs-only change).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/plan/multi-group-filter.md | Plan for unified graph + group visibility filtering architecture and UI. |
| docs/plan/logical-visual-split.md | Plan for separating logical layout roles from pixel geometry/animation, with phased migration. |
Comment on lines
+122
to
+127
| enum Roles { UuidRole, NameRole, VisibleRole, SizeRole, ColorRole }; | ||
|
|
||
| // QAbstractListModel interface | ||
| int rowCount(...) const override; | ||
| QVariant data(const QModelIndex&, int role) const override; | ||
| bool setData(const QModelIndex&, const QVariant&, int role) override; // for VisibleRole |
|
|
||
| ### Phase A — `ForestPosition` + `GroupPosition` + `ForestLayout` + `GroupLayout` (C++ only) | ||
|
|
||
| - [ ] Create `source/model/group/ForestPosition.hpp` — `struct ForestPosition { int forestIndex; int depth; int stackPos; }` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.