Project cleanup - #550
Merged
Merged
Conversation
…eamline initialization
…ion and dependency installation
…ndency installation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the repository’s build workflow by consolidating dependency installation + configuration steps into a new --bootstrap command in project.py, updating documentation/CI accordingly, and removing CMake workflow presets.
Changes:
- Replace
--deps-install/ workflow-preset build flow with--bootstrap+ explicitcmake --build --preset .... - Remove
workflowPresetsfromCMakePresets.jsonand update CI + docs to use the new command. - Remove the
tools/check_project_script.pyhelper script.
Testing:
- Not run (not provided in PR metadata).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/check_project_script.py | Removes a project-script smoke-check helper. |
| README.md | Updates build instructions to use --bootstrap. |
| project.py | Introduces --bootstrap, moves submodule/deps/configure logic into Project, and switches build to cmake --build. |
| CMakePresets.json | Removes workflowPresets now that cmake --workflow is no longer used. |
| .github/workflows/ci.yml | Updates CI dependency step to call --bootstrap. |
| .github/copilot-instructions.md | Updates documented build command to --bootstrap. |
Comment on lines
+145
to
+146
| if args.bootstrap: | ||
| app.bootstrap(args.preset, force=True) |
|
|
||
| # Should be possible to run: | ||
| # ./project.py --deps-install [--preset desktop_release (default) | desktop_dev | wasm_release] | ||
| # ./project.py --bootstrap [--preset desktop_release (default) | desktop_dev | wasm_release] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.