Skip to content

Add timeouts to workflow jobs - #535

Merged
kiftio merged 1 commit into
mainfrom
07-29-add_timeouts_to_workflow_jobs
Jul 29, 2026
Merged

Add timeouts to workflow jobs#535
kiftio merged 1 commit into
mainfrom
07-29-add_timeouts_to_workflow_jobs

Conversation

@kiftio

@kiftio kiftio commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Adds timeout-minutes to every GitHub Actions job that runs directly on a runner. Without explicit timeouts, jobs can hang indefinitely and consume CI minutes unnecessarily. A new test (scripts/test/workflow_timeouts_test.rb) enforces this going forward by asserting that every non-reusable job in .github/workflows/ declares a timeout-minutes value.

How to test

  • Run the new test locally with ruby scripts/test/workflow_timeouts_test.rb and confirm it passes.
  • Verify that any future workflow job added without a timeout-minutes causes the test to fail.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kiftio kiftio mentioned this pull request Jul 29, 2026
11 tasks
@kiftio
kiftio marked this pull request as ready for review July 29, 2026 09:38
@kiftio
kiftio requested a review from a team as a code owner July 29, 2026 09:38
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
99.2% (249/251) 85.49% (112/131) 100% (70/70)

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@github-actions

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Web npm tarball 65.5 KiB 65.5 KiB 0 B
React Native npm tarball 103.1 KiB 103.1 KiB 0 B
Android release AAR 260.3 KiB 260.3 KiB 0 B
Web file breakdown
File Base Head Delta
dist/index.js.map 184.1 KiB 184.1 KiB 0 B
dist/index.d.ts 41.9 KiB 41.9 KiB 0 B
dist/custom-elements.json 40.1 KiB 40.1 KiB 0 B
dist/index.js 29.6 KiB 29.6 KiB 0 B
README.md 17.8 KiB 17.8 KiB 0 B
package.json 2.8 KiB 2.8 KiB 0 B
LICENSE 1.1 KiB 1.1 KiB 0 B
React Native file breakdown
File Base Head Delta
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.ts 85.4 KiB 85.4 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.d.ts 53.0 KiB 53.0 KiB 0 B
ios/ShopifyCheckoutKit.swift 15.0 KiB 15.0 KiB 0 B
ios/AcceleratedCheckoutButtons.swift 14.0 KiB 14.0 KiB 0 B
lib/commonjs/index.js 13.1 KiB 13.1 KiB 0 B
src/components/AcceleratedCheckoutButtons.tsx 12.9 KiB 12.9 KiB 0 B
src/index.ts 12.5 KiB 12.5 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js 11.4 KiB 11.4 KiB 0 B
android/src/main/java/com/shopify/reactnative/checkoutkit/ShopifyCheckoutKitModule.java 11.1 KiB 11.1 KiB 0 B
lib/module/index.js 10.4 KiB 10.4 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js.map 10.3 KiB 10.3 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js 10.2 KiB 10.2 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.ts 9.5 KiB 9.5 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js.map 9.1 KiB 9.1 KiB 0 B
src/index.d.ts 8.9 KiB 8.9 KiB 0 B
lib/module/index.js.map 8.2 KiB 8.2 KiB 0 B
src/present-dispatcher.ts 8.0 KiB 8.0 KiB 0 B
lib/commonjs/index.js.map 7.7 KiB 7.7 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.d.ts 7.6 KiB 7.6 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolRenameMap.ts 7.2 KiB 7.2 KiB 0 B
…and 110 smaller files
Android file breakdown
File Base Head Delta
classes.jar 276.3 KiB 276.3 KiB 0 B
res/layout/checkout_view_content.xml 2.2 KiB 2.2 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.2 KiB 1.2 KiB 0 B
R.txt 1.1 KiB 1.1 KiB 0 B
proguard.txt 798 B 798 B 0 B
AndroidManifest.xml 578 B 578 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@kiftio
kiftio changed the base branch from 07-29-key_react_native_gem_cache_by_ruby_interpreter to graphite-base/535 July 29, 2026 10:17

kiftio commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 29, 10:37 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 29, 11:17 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.

@kiftio
kiftio changed the base branch from graphite-base/535 to main July 29, 2026 11:16
Assisted-By: devx/4075c309-3611-4ac8-9ea7-26a8974e7963
@kiftio
kiftio force-pushed the 07-29-add_timeouts_to_workflow_jobs branch from ac39d90 to b15340a Compare July 29, 2026 11:25
@kiftio
kiftio merged commit c80d4c3 into main Jul 29, 2026
35 checks passed
@kiftio
kiftio deleted the 07-29-add_timeouts_to_workflow_jobs branch July 29, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants