fix: allow tophat to recover/force a rebuild after a 404 - #608
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
fix: allow tophat to recover/force a rebuild after a 404#608kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
I was attempting to test a PR and noticed that the download link wasn't working, whilst these run on bitrise it was around the time of the github outage, and resolved outside of that time period
I decided to add a few more options to tophat to make it function in these cases
404 => "This usually means the artifact expired or no longer matches. Run\n dev tophat --force-rebuild to trigger a fresh build and retry."--verboseflag to get some extra log output when things go wrong--force-rebuildflag to trigger another build if the artifact is available but doesn't actually install for some reason (e.g. corrupt download), running with this flag will wait for the build to finish then launch the next fzf question or launch the appHow to test
Can't really test the 404 part until it hits again, but the
--force-rebuildflag is testable, find a PR that has a bitrise build already, and run the following, then watch the bitrise portal for another trigger to appear, once that build finishes you should see the prompt has stopped waiting and pushed you to either the simulator or asked you to fill in the device you wish to test onBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.