[Tests] Replace filesystem mocks with real temp directories in bundle.test.ts#7878
[Tests] Replace filesystem mocks with real temp directories in bundle.test.ts#7878gonzaloriestra wants to merge 1 commit into
Conversation
….test.ts Refactored `packages/app/src/cli/services/extensions/bundle.test.ts` to use `inTemporaryDirectory` instead of mocking `@shopify/cli-kit/node/fs`. This improves test reliability by exercising the real filesystem implementation and avoids global mocks that can interfere with other tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Following best practices to use real temporary directories instead of mocking the filesystem in tests.
WHAT is this pull request doing?
Refactored
bundleExtensiontests inpackages/app/src/cli/services/extensions/bundle.test.tsto useinTemporaryDirectoryandreadFile/fileExistsSyncfor assertions. Removed the globalvi.mock('@shopify/cli-kit/node/fs')block.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 7849776053424436107 started by @gonzaloriestra