Skip to content

[Tests] Replace filesystem mocks with real temp directories in bundle.test.ts - #7878

Merged
gonzaloriestra merged 1 commit into
mainfrom
tests-remove-fs-mock-bundle-extension-7849776053424436107
Jul 10, 2026
Merged

[Tests] Replace filesystem mocks with real temp directories in bundle.test.ts#7878
gonzaloriestra merged 1 commit into
mainfrom
tests-remove-fs-mock-bundle-extension-7849776053424436107

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Following best practices to use real temporary directories instead of mocking the filesystem in tests.

WHAT is this pull request doing?

Refactored bundleExtension tests in packages/app/src/cli/services/extensions/bundle.test.ts to use inTemporaryDirectory and readFile/fileExistsSync for assertions. Removed the global vi.mock('@shopify/cli-kit/node/fs') block.

How to test your changes?

CI

Post-release steps

None

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 7849776053424436107 started by @gonzaloriestra

@gonzaloriestra
[Tests] Replace filesystem mocks with real temp directories in bundle…
e572e71 
….test.ts

Refactored `packages/app/src/cli/services/extensions/bundle.test.ts` to use `inTemporaryDirectory` instead of mocking `@shopify/cli-kit/node/fs`.

This improves test reliability by exercising the real filesystem implementation and avoids global mocks that can interfere with other tests.
@google-labs-jules

google-labs-jules Bot commented Jun 21, 2026

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 21, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review July 1, 2026 11:25
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner July 1, 2026 11:25
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jul 1, 2026
isaacroldan
isaacroldan approved these changes Jul 10, 2026
View reviewed changes

@isaacroldan isaacroldan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: behavior-preserving refactor / test-only change, CI green. Safe to merge.

@gonzaloriestra Graphite App

gonzaloriestra commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 10, 11:02 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 10, 11:02 AM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit b202f78 Jul 10, 2026
30 checks passed
@gonzaloriestra
gonzaloriestra deleted the tests-remove-fs-mock-bundle-extension-7849776053424436107 branch July 10, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

Assignees

No one assigned

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gonzaloriestra @isaacroldan