Skip to content

Remove @shopify/react-i18n#6919

Open
gonzaloriestra wants to merge 1 commit intomainfrom
remove-react-i18n
Open

Remove @shopify/react-i18n#6919
gonzaloriestra wants to merge 1 commit intomainfrom
remove-react-i18n

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Mar 2, 2026

WHY are these changes introduced?

There's a warning about @shopify/react-i18n being deprecated:

❯ pnpm install
Scope: all 14 workspace projects
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-i18n@7.14.0
 WARN  14 deprecated subdependencies found: @shopify/dates@2.1.1, @shopify/function-enhancers@3.1.0, @shopify/i18n@2.1.0, @shopify/name@1.3.0, @shopify/react-effect@5.2.0, @shopify/react-hooks@4.1.2, @shopify/useful-types@5.3.0, boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +12
++++++++++++
Progress: resolved 1991, reused 1841, downloaded 0, added 1, done
Done in 3.8s using pnpm v10.11.1

WHAT is this pull request doing?

Removes the depency:

❯ pnpm install
Scope: all 14 workspace projects
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
 WARN  8 deprecated subdependencies found: @shopify/useful-types@5.3.0, boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +16 -1
++++++++++++++++-
Progress: resolved 1980, reused 1830, downloaded 0, added 1, done
Done in 4.4s using pnpm v10.11.1

How to test your changes?

pnpm install

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@gonzaloriestra gonzaloriestra mentioned this pull request Mar 2, 2026
5 tasks
Copy link
Contributor Author

gonzaloriestra commented Mar 2, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.24% 14572/18866
🟡 Branches 70.88% 7228/10198
🟡 Functions 76.23% 3704/4859
🟡 Lines 78.74% 13776/17495

Test suite run success

3798 tests passing in 1460 suites.

Report generated by 🧪jest coverage report action from 00cbf48

@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from e5365bc to 51ac217 Compare March 2, 2026 12:03
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from 51ac217 to 131e313 Compare March 2, 2026 14:48
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from 131e313 to dfd3d96 Compare March 3, 2026 10:49
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from dfd3d96 to 24611bb Compare March 3, 2026 15:49
@gonzaloriestra gonzaloriestra marked this pull request as ready for review March 4, 2026 11:43
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner March 4, 2026 11:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@binks-code-reviewer
Copy link

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - 1 findings

📋 History

✅ 1 findings

@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from 24611bb to a50948b Compare March 12, 2026 12:51
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from a50948b to 2c5d9c2 Compare March 12, 2026 12:53
@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from 2c5d9c2 to 01288c4 Compare March 12, 2026 13:14
Copy link
Contributor

@ryancbahan ryancbahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this effectively a direct port of our internal package in world? Or does it diverge? Just want to make sure we're pulling from prior art where possible.

@gonzaloriestra gonzaloriestra force-pushed the fix-deprecated-dependencies branch from 01288c4 to 07e8a05 Compare March 12, 2026 15:52
Copy link
Contributor Author

Yeah, it's basically including the required functionality from https://github.com/Shopify/quilt/blob/main/packages/react-i18n

Anyway, the CLI is not translated and this is only used for the local dev console that will be removed soon (when 1P is migrated to Dev Dash). So I wouldn't worry too much about the approach.

Base automatically changed from fix-deprecated-dependencies to main March 12, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants