Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f6552e9 to
08f4907
Compare
c19a23f to
41d6f79
Compare
08f4907 to
e5365bc
Compare
41d6f79 to
8cc1829
Compare
Coverage report
Test suite run success3798 tests passing in 1460 suites. Report generated by 🧪jest coverage report action from 00cbf48 |
e5365bc to
51ac217
Compare
8cc1829 to
8ca6ef2
Compare
51ac217 to
131e313
Compare
8ca6ef2 to
ec4e89f
Compare
131e313 to
dfd3d96
Compare
ec4e89f to
6851617
Compare
dfd3d96 to
24611bb
Compare
6851617 to
fb4bc7a
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - 1 findings 📋 History✅ 1 findings |
fb4bc7a to
c7c1079
Compare
24611bb to
a50948b
Compare
c7c1079 to
6066d83
Compare
a50948b to
2c5d9c2
Compare
6066d83 to
0cc1b77
Compare
2c5d9c2 to
01288c4
Compare
ryancbahan
left a comment
There was a problem hiding this comment.
Is this effectively a direct port of our internal package in world? Or does it diverge? Just want to make sure we're pulling from prior art where possible.
01288c4 to
07e8a05
Compare
0cc1b77 to
00cbf48
Compare
|
Yeah, it's basically including the required functionality from https://github.com/Shopify/quilt/blob/main/packages/react-i18n Anyway, the CLI is not translated and this is only used for the local dev console that will be removed soon (when 1P is migrated to Dev Dash). So I wouldn't worry too much about the approach. |

WHY are these changes introduced?
There's a warning about
@shopify/react-i18nbeing deprecated:WHAT is this pull request doing?
Removes the depency:
How to test your changes?
pnpm installMeasuring impact
How do we know this change was effective? Please choose one:
Checklist