Skip to content

Upgrade H3#6954

Open
gonzaloriestra wants to merge 1 commit intomainfrom
upgrade-h3
Open

Upgrade H3#6954
gonzaloriestra wants to merge 1 commit intomainfrom
upgrade-h3

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Mar 9, 2026

WHY are these changes introduced?

Related to https://github.com/shop/issues-develop/issues/22049
Fixes https://github.com/Shopify/cli/security/dependabot/202

WHAT is this pull request doing?

Upgrades H3 to the latest version for both app and theme packages

How to test your changes?

  • shopify app dev
  • shopify theme dev

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.23% 14547/18837
🟡 Branches 70.91% 7217/10178
🟡 Functions 76.2% 3698/4853
🟡 Lines 78.72% 13752/17469

Test suite run success

3806 tests passing in 1462 suites.

Report generated by 🧪jest coverage report action from 4546d39

@gonzaloriestra
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260309115726

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 9, 2026
@gonzaloriestra gonzaloriestra force-pushed the upgrade-h3 branch 2 times, most recently from 57af2d4 to 228db89 Compare March 12, 2026 12:37
@gonzaloriestra gonzaloriestra marked this pull request as ready for review March 12, 2026 13:02
@gonzaloriestra gonzaloriestra requested review from a team as code owners March 12, 2026 13:02
@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

- node-pty
- nx
- protobufjs
- unrs-resolver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear on why we need to add this. Peer dep of H3's new major version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It asked me to add it when I ran pnpm install. I thought it was a new dependency, but apparently it was added in the ESLint migration (recently). Not sure why it didn't ask before :thinking_face:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants