remove simple git

[ryancbahan]

WHY are these changes introduced?

This change removes the dependency on the simple-git library and replaces it with direct git command execution using execa. This PR is part of an assertion I believe to be true: with the rise of agentic development and parallel rise of supply chain attacks, external dependencies have become less valuable and higher risk. We should be looking at our dependencies with a critical eye and removing ones that don't have a very clear value proposition.

Testing

• shopify app init
• shopify theme init
• shopify app generate extension

[ryancbahan]

• remove simple git #6976 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[binks-code-reviewer]

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - 5 findings

📋 History

✅ 5 findings

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	79.19%	14601/18437
🟡	Branches	73.44%	7258/9883
🟡	Functions	79.36%	3706/4670
🟡	Lines	79.52%	13803/17357

Test suite run success

3822 tests passing in 1464 suites.

Report generated by 🧪jest coverage report action from 9384aee

[dmerand]

I'm aligned with this approach. AI pair review found some bugs worth double-checking.

---

Review assisted by pair-review

[dmerand]

(Ref Line 152) 🐛 Bug: The progressUpdater parameter is still declared in the GitCloneOptions interface but is no longer used in the implementation (removed at line 160). This is a silent breaking change - callers can pass this parameter expecting progress updates, but it will be ignored without any error or warning. While no code in the codebase currently uses this parameter, it's still part of the public API contract.

Suggestion: Either remove the parameter from the interface to accurately reflect the implementation, or add a deprecation notice:

Suggested change

	/** @deprecated Progress updates are no longer supported after removing simple-git dependency */
	progressUpdater?: (statusString: string) => void

Alternatively, implement progress tracking using execa's stdio events, or remove it entirely with a migration note.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/git.d.ts

@@ -1,5 +1,13 @@
 import { AbortError } from './error.js';
-import { DefaultLogFields, ListLogLine } from 'simple-git';
+export interface GitLogEntry {
+    hash: string;
+    date: string;
+    message: string;
+    refs: string;
+    body: string;
+    author_name: string;
+    author_email: string;
+}
 /**
  * Initialize a git repository at the given directory.
  *
@@ -40,14 +48,12 @@ export declare function addToGitIgnore(root: string, entry: string): void;
  *
  * @param repoUrl - The URL of the repository to clone.
  * @param destination - The directory where the repository will be cloned.
- * @param progressUpdater - A function that will be called with the progress of the clone.
  * @param shallow - Whether to clone the repository shallowly.
  * @param latestTag - Whether to clone the latest tag instead of the default branch.
  */
 export interface GitCloneOptions {
     repoUrl: string;
     destination: string;
-    progressUpdater?: (statusString: string) => void;
     shallow?: boolean;
     latestTag?: boolean;
 }
@@ -64,7 +70,7 @@ export declare function downloadGitRepository(cloneOptions: GitCloneOptions): Pr
  * @param directory - The directory of the git repository.
  * @returns The latest commit of the repository.
  */
-export declare function getLatestGitCommit(directory?: string): Promise<DefaultLogFields & ListLogLine>;
+export declare function getLatestGitCommit(directory?: string): Promise<GitLogEntry>;
 /**
  * Add all files to the git index from the given directory.
  *

[dmerand]

Thanks for the changes! Tophat LGTM.