Skip to content

Remove fixed wait from dev hot reload E2E #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alfonso-noriega wants to merge 1 commit into from
Closed

Remove fixed wait from dev hot reload E2E #7844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/e2e/tests/dev-hot-reload.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,6 @@ test.describe('Dev hot reload', () => {
writeFlowTriggerExtension(appDir, 'doomed-ext')
await proc.waitForOutput('Extension created', CLI_TIMEOUT.medium)

// Wait for the dev session to settle before deleting
await new Promise((resolve) => setTimeout(resolve, 5000))

fs.rmSync(path.join(appDir, 'extensions', 'doomed-ext'), {recursive: true, force: true})

await proc.waitForOutput('Extension deleted', CLI_TIMEOUT.medium)
Expand Down
Loading