Skip to content

[Refactor] Improve session scope generation logic #7850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Jul 10, 2026
+6 −5
Merged

[Refactor] Improve session scope generation logic #7850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/cli-kit/src/private/node/session/scopes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {allAPIs, API} from '../api.js'
import {BugError} from '../../../public/node/error.js'
import {uniq} from '../../../public/common/array.js'

/**
* Generate a flat array with all the default scopes for all the APIs plus
Expand All @@ -8,9 +9,9 @@ import {BugError} from '../../../public/node/error.js'
* @returns Array of scopes
*/
export function allDefaultScopes(extraScopes: string[] = []): string[] {
let scopes = allAPIs.map((api) => defaultApiScopes(api)).flat()
scopes = ['openid', ...scopes, ...extraScopes].map(scopeTransform)
return Array.from(new Set(scopes))
const scopes = allAPIs.flatMap((api) => defaultApiScopes(api))
const allScopes = ['openid', ...scopes, ...extraScopes].map(scopeTransform)
return uniq(allScopes)
}

/**
Expand All @@ -21,8 +22,8 @@ export function allDefaultScopes(extraScopes: string[] = []): string[] {
* @returns Array of scopes
*/
export function apiScopes(api: API, extraScopes: string[] = []): string[] {
const scopes = [...defaultApiScopes(api), ...extraScopes.map(scopeTransform)].map(scopeTransform)
return Array.from(new Set(scopes))
const scopes = [...defaultApiScopes(api), ...extraScopes].map(scopeTransform)
return uniq(scopes)
}

/**
Expand Down
Loading