[Tests] Remove filesystem mocks in app init command tests - #7852
Conversation
Refactored `packages/app/src/cli/commands/app/init.test.ts` to use `inTemporaryDirectory` for real filesystem operations instead of mocking `@shopify/cli-kit/node/fs`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
isaacroldan
left a comment
isaacroldan
left a comment
There was a problem hiding this comment.
Reviewed: behavior-preserving refactor / test-only change, CI green. Safe to merge.
Merge activity
|
2 participants
WHY are these changes introduced?
Filesystem mocking can lead to tests that don't accurately reflect real-world behavior and are brittle to changes in the underlying implementation of filesystem utilities.
WHAT is this pull request doing?
Refactors
packages/app/src/cli/commands/app/init.test.tsto use real temporary directories viainTemporaryDirectoryinstead of mocking@shopify/cli-kit/node/fs.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 9629675890244724247 started by @gonzaloriestra