Skip to content

[Refactor] Extract adminUrl helper in themes/urls.ts - #8254

Merged
gonzaloriestra merged 1 commit into
mainfrom
refactor-themes-urls-11628264692596972264
Aug 10, 2026
Merged

gonzaloriestra merged 1 commit into
mainfrom
refactor-themes-urls-11628264692596972264

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The URL construction functions in packages/cli-kit/src/public/node/themes/urls.ts repeated the string interpolation logic for constructing store admin URLs (https://${store}/admin...).

This PR refactors them by introducing a private helper function adminUrl to centralize this formatting logic, improving maintainability and reducing code duplication.

WHAT is this pull request doing?

  • Extracts adminUrl(store: string, path = ''): string helper function.
  • Updates themeEditorUrl, codeEditorUrl, storeAdminUrl, and storePasswordPage to delegate URL generation to adminUrl.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 11628264692596972264 started by @gonzaloriestra

Extract private helper function adminUrl to handle FQDN formatting and path appending, thereby eliminating redundant URL string interpolations across themeEditorUrl, codeEditorUrl, storeAdminUrl, and storePasswordPage.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 6, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Aug 10, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review August 10, 2026 08:55
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner August 10, 2026 08:55

gonzaloriestra commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 10, 1:31 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 10, 1:31 PM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit ea83fbb Aug 10, 2026
31 checks passed
@gonzaloriestra
gonzaloriestra deleted the refactor-themes-urls-11628264692596972264 branch August 10, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants