Conversation
Assisted-By: devx/6a87267f-002b-45a7-a964-2b150210ff87
Assisted-By: devx/6a87267f-002b-45a7-a964-2b150210ff87
lopez-mar
force-pushed
the
lopez-mar/app-doctor-agentic-auth
branch
from
September 21, 2026 17:48
82d6ca0 to
63ce5d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Partners using
context.shopify.authenticate.admin(request)receive missing-authentication findings because the existing template heuristic does not recognize that wiring. Recognizing the spelling does not prove that verification protects the operation, and maintaining a custom authentication analyzer is disproportionate to this fix.WHAT is this pull request doing?
Retain the existing React Router template heuristic. When a handler contains
context.shopify.authenticate.admin(...), defer that handler to agent review rather than reporting missing authentication or treating it as verified. Record unresolved coverage and pass the relevant files and guidance through the review pack; retain ordinary heuristic findings in other handlers.Keep the strengthened agent prompt for context provenance, wrappers, verification order, and failure handling. Remove the custom AST analyzer, its app-level dependency, and parser-specific tests in favor of focused handoff regressions.
This remains a heuristic, not proof of route security. Existing template-heuristic limitations and severity-based blocking behavior are unchanged.
How to manually test your changes?
pnpm shopify app security check --path "$APP_PATH" --jsonChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add