Skip to content

Defer context-based route authentication to agent review - #8596

Open
lopez-mar wants to merge 4 commits into
mainfrom
lopez-mar/app-doctor-agentic-auth
Open

lopez-mar wants to merge 4 commits into
mainfrom
lopez-mar/app-doctor-agentic-auth

Conversation

@lopez-mar

@lopez-mar lopez-mar commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Partners using context.shopify.authenticate.admin(request) receive missing-authentication findings because the existing template heuristic does not recognize that wiring. Recognizing the spelling does not prove that verification protects the operation, and maintaining a custom authentication analyzer is disproportionate to this fix.

WHAT is this pull request doing?

Retain the existing React Router template heuristic. When a handler contains context.shopify.authenticate.admin(...), defer that handler to agent review rather than reporting missing authentication or treating it as verified. Record unresolved coverage and pass the relevant files and guidance through the review pack; retain ordinary heuristic findings in other handlers.

Keep the strengthened agent prompt for context provenance, wrappers, verification order, and failure handling. Remove the custom AST analyzer, its app-level dependency, and parser-specific tests in favor of focused handoff regressions.

This remains a heuristic, not proof of route security. Existing template-heuristic limitations and severity-based blocking behavior are unchanged.

How to manually test your changes?

pnpm shopify app security check --path "$APP_PATH" --json

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@lopez-mar
lopez-mar requested a review from a team as a code owner September 18, 2026 21:11
@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Sep 18, 2026
@lopez-mar lopez-mar changed the title Move App Doctor route authentication review to the agent Use bounded AST analysis for App Security route authentication Sep 21, 2026
Assisted-By: devx/6a87267f-002b-45a7-a964-2b150210ff87
Assisted-By: devx/6a87267f-002b-45a7-a964-2b150210ff87
@lopez-mar
lopez-mar force-pushed the lopez-mar/app-doctor-agentic-auth branch from 82d6ca0 to 63ce5d1 Compare September 21, 2026 17:48
@lopez-mar lopez-mar changed the title Use bounded AST analysis for App Security route authentication Defer context-based route authentication to agent review Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant